Updates for tsconfig generation #12420
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 77dfc47:
|
Makefile
Outdated
Comment on lines
149
to
155
| rm -f packages/*/tsconfig.{tsbuildinfo,json} | ||
| rm -f codemods/*/tsconfig.{tsbuildinfo,json} | ||
| rm -f eslint/*/tsconfig.{tsbuildinfo,json} | ||
| # revert files in git | ||
| git checkout HEAD -- packages/*/tsconfig.json | ||
| git checkout HEAD -- codemods/*/tsconfig.json | ||
| git checkout HEAD -- eslint/*/tsconfig.json |
There was a problem hiding this comment.
We can use git clean, that only removes files if they are ignored:
Suggested change
| rm -f packages/*/tsconfig.{tsbuildinfo,json} | |
| rm -f codemods/*/tsconfig.{tsbuildinfo,json} | |
| rm -f eslint/*/tsconfig.{tsbuildinfo,json} | |
| # revert files in git | |
| git checkout HEAD -- packages/*/tsconfig.json | |
| git checkout HEAD -- codemods/*/tsconfig.json | |
| git checkout HEAD -- eslint/*/tsconfig.json | |
| git clean packages/*/tsconfig.json -xfq | |
| git clean codemods/*/tsconfig.json -xfq | |
| git clean eslint/*/tsconfig.json -xfq | |
| rm -f */*/tsconfig.tsbuildinfo |
nicolo-ribaudo
approved these changes
Dec 4, 2020
nicolo-ribaudo
added this to To review
in Nicolò's ideal PR review order list
via automation
JLHwung
approved these changes
Dec 9, 2020
github-actions
bot
added
the
outdated
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tsconfigs.jsonfiles already in git, are not removed inclean-tsconfigscripts/generators/tsconfig.jsto also generatetsconfig.jsonfiles foreslintandcodemodsfolders